[view] 유저 정보 매칭 실패시 유저 아이콘 클릭 비활성화 #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxxmnmn
reviewed
Oct 2, 2024
| @@ -5,24 +5,33 @@ import type { AuthorInfo } from "types"; | |||
| import { GITHUB_URL } from "../../../constants/constants"; | |||
|
|
|||
| const Author = ({ name, src }: AuthorInfo) => { | |||
| const isUser = src.includes(GITHUB_URL); | |||
There was a problem hiding this comment.
조금 더 구체적으로 isGitHubUser와 같이 네이밍 해도 좋을 것 같아요!
There was a problem hiding this comment.
좋은 의견 감사합니다!! 추후 반영하도록 하겠습니다.
yoouyeon
approved these changes
Oct 2, 2024
Comment on lines
+22
to
33
| <Avatar | ||
| alt={name} | ||
| src={src} | ||
| sx={{ width: 30, height: 30, minWidth: 30, minHeight: 30, cursor: "pointer" }} | ||
| /> | ||
| </a> | ||
| ) : ( | ||
| <Avatar | ||
| alt={name} | ||
| src={src} | ||
| sx={{ width: 30, height: 30, minWidth: 30, minHeight: 30, cursor: "pointer" }} | ||
| sx={{ width: 30, height: 30, minWidth: 30, minHeight: 30 }} | ||
| /> |
There was a problem hiding this comment.
Avatar의 스타일 코드들이 중복으로 사용되고 있는데
const avatarStyle = { width: 30, height: 30, minWidth: 30, minHeight: 30, cursor: isUser ? "pointer" : "default" };
이런 식으로 변수에 담아서 써도 괜찮을 것 같아요!
There was a problem hiding this comment.
의견 감사합니다!! 좋은 방법인 것 같아요👍 추후 수정하겠습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#571
Result
2024-10-02.5.44.38.mov
2024-10-02.5.42.45.mov
Work list
Discussion