[view] AuthorBarChart util 함수 테스트 코드 작성 #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
approved these changes
Sep 30, 2024
| import { getDataByAuthor } from "./AuthorBarChart.util"; | ||
|
|
||
| describe("getDataByAuthor", () => { | ||
| it("should return empty array if no data is provided", () => { |
| commit: 2, | ||
| insertion: 7, | ||
| deletion: 4, | ||
| }, |
There was a problem hiding this comment.
(사소) 기왕이면 Type 선언도 하면 좋지 않을까요? 😸
There was a problem hiding this comment.
approve를 두 개 받아버려서..!! 다음 tc pr 올릴 때 함께 반영해서 올리도록 하겠습니다! 감사합니다🙂🙂🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Result
Work list
AuthorBarChart util 함수의 테스트 코드를 작성했습니다.
Discussion