Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] #669 클러스터 클릭 관련 TC 테스트 코드 수정 #670

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

yuiseo
Copy link
Member

@yuiseo yuiseo commented Aug 25, 2024

Related issue

#669

Result

수정 전
image

수정 후
image

Work list

  • view package의 터미널에서 npm run test:e2e 실행 시,
    기존에 존재하는 실패하는 테스트 케이스를 분석하여 원인을 수정하고
    테스트 케이스의 의도를 명확하게 수정하였습니다.

Discussion

  • 리뷰를 참고해주세요!

@yuiseo yuiseo requested review from a team as code owners August 25, 2024 15:16
@yuiseo yuiseo self-assigned this Aug 25, 2024
Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 드뎌 e2e 시동이 걸리는군요!!

@ytaek
Copy link
Contributor

ytaek commented Aug 26, 2024

이번 PR 후에, CI에서도 다시 e2e를 돌릴 수 있도록
주석 처리한 부분을 풀어도 좋을 것 같습니다! 고고!

@yuiseo yuiseo changed the title test: #669 클러스터 클릭 관련 TC 테스트 코드 수정 [test] #669 클러스터 클릭 관련 TC 테스트 코드 수정 Aug 26, 2024
@yuiseo
Copy link
Member Author

yuiseo commented Aug 26, 2024

이번 PR 후에, CI에서도 다시 e2e를 돌릴 수 있도록 주석 처리한 부분을 풀어도 좋을 것 같습니다! 고고!

@ytaek
넵! 감사합니다! 이후에 e2e 테스트 관련 CI 코드 수정해보도록 하겠습니다!

Copy link
Contributor

@choisohyun choisohyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👏 수고하셨습니다!

@yuiseo yuiseo merged commit 48065ce into githru:main Aug 29, 2024
2 checks passed
@seungineer seungineer added this to the v0.7.1 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants