[view] 커밋 링크 추가 #668
Merged
[view] 커밋 링크 추가 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
approved these changes
Aug 25, 2024
| @@ -84,15 +85,15 @@ const Detail = ({ selectedData, clusterId, authSrcMap }: DetailProps) => { | |||
| </span> | |||
| </div> | |||
| <div className="commit-id"> | |||
| <span | |||
| <a | |||
| href={`https://github.com/${owner}/${repo}/commit/${id}`} | |||
There was a problem hiding this comment.
해당 기능에 추가로, github.com 외의 도메인도 지원하게 하자는 #465 이슈도 추후에 고려해주셨으면 좋겠습니다~~
(enterprise github등을 쓰는 경우에는 github.com 이 아닌 다른 도메인도 쓰인답니다!)
| onClick={handleCommitIdCopy(id)} | ||
| role="button" | ||
| tabIndex={0} | ||
| onKeyDown={handleCommitIdCopy(id)} |
There was a problem hiding this comment.
onkeydown 은 저도 왜 있는지 모르겠네요 ^^;;
(말씀해주신걸 보니, 이제야 기억이 났네요;; 해당 기능은 git-graph에 있는 것처럼, commit ID를 눌리면 hash 값이 복사되어서, checkout할 때 등등 사용할 수 있도록 하는 기능이었습니다)
위 사항들 잘게 쪼개서 이슈로 등록해주시면 좋을 것 같고,
|
|
리뷰 감사합니다!ㅎㅎ말씀주신 부분들 잘 정리해서 이슈로 등록해둘게요!! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#534
Result
2024-08-25.6.37.01.mov
Work list
Discussion