Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build and publish docker image #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hroussez
Copy link

@hroussez hroussez commented Jul 16, 2024

this pr adds github actions workflow config to build and push the docker image on every pr and commit to main

tested on hroussez#1

note: merging this pr requires changing the default branch from master to main beforehand

Copy link
Owner

@giovtorres giovtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is great! Thank you for putting this together. Apologies for the delay responding. I did rename the default branch to main.

I just had one potential tweak.

if: github.event_name != 'pull_request'
uses: sigstore/cosign-installer@59acb6260d9c0ba8f4a2f9d9b48431a222b68e20 #v3.5.0
with:
cosign-release: 'v2.2.4'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be 'v2' instead so as to pull in all the patch updates over time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants