-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes formulas for Sor #1720
Fixes formulas for Sor #1720
Conversation
* $\omega$ is known as the relaxation factor. | ||
* The preconditioner can be made symmetric, leading to the SSOR preconitioner. | ||
* Here, $M$ is defined as | ||
* $$ | ||
* \f[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought \[
is enough, does it need to \f[
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No \[
doesn't work, it has to be \f[
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you also look this page https://www.doxygen.nl/manual/formulas.html
maybe we or they have the tranformation from $
to \f$
? I wonder the transformation makes \f[
to \ff[
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit confused by that, somehow \f$
didn't work, but $
works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found we have used \f[
and the formula is shown in https://ginkgo-project.github.io/ginkgo-generated-documentation/doc/develop/classgko_1_1matrix_1_1Fft.html.
I think we can rely on \f[
* $\omega$ is known as the relaxation factor. | ||
* The preconditioner can be made symmetric, leading to the SSOR preconitioner. | ||
* Here, $M$ is defined as | ||
* $$ | ||
* \f[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found we have used \f[
and the formula is shown in https://ginkgo-project.github.io/ginkgo-generated-documentation/doc/develop/classgko_1_1matrix_1_1Fft.html.
I think we can rely on \f[
572e2db
to
daae47b
Compare
Error: PR already merged! |
This merge fixes the formulas for SOR by using `\f[` instead of `$$` (or `\[`). Related PR: ginkgo-project#1720
This PR fixes the SOR (and Gauss-Seidel) documentation.