Remove pre cuda 11 code #1715
Merged
Remove pre cuda 11 code #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
mod:cuda
upsj
approved these changes
Oct 28, 2024
| @@ -886,7 +459,7 @@ inline void destroy(cusparseSpMatDescr_t descr) | |||
| } | |||
|
|
|||
|
|
|||
| #if (CUDA_VERSION >= 11031) | |||
| #if defined(CUDA_VERSION) && (CUDA_VERSION >= 11031) | |||
There was a problem hiding this comment.
Not sure if we even need these - the file should fail to compile if it's not compiled by nvcc or not including the necessary headers.
There was a problem hiding this comment.
I would just leave it, it's not hurting.
yhmtsai
approved these changes
Oct 28, 2024
MarcelKoch
force-pushed
the
remove-pre-cuda11
branch
from
ab3df44 to
1414433
Compare
MarcelKoch
added
1:ST:ready-to-merge
Co-authored-by: Tobias Ribizel <[email protected]>
MarcelKoch
force-pushed
the
remove-pre-cuda11
branch
from
1414433 to
8e08058
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1715 +/- ##
===========================================
- Coverage 89.33% 89.33% -0.01%
===========================================
Files 779 779
Lines 63430 63429 -1
===========================================
- Hits 56663 56662 -1
Misses 6767 6767 ☔ View full report in Codecov by Sentry. |
MarcelKoch
added a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This PR remove all `#if` branches for CUDA < 11. Related PR: ginkgo-project#1715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove all
#ifbranches for CUDA < 11.