Half factorization #1712
Merged
Half factorization #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
yhmtsai
force-pushed
the
half_factorization
branch
from
3db59fd to
cd9677a
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
cd9677a to
5e5cd03
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
5e5cd03 to
c276034
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
c276034 to
bbefde6
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
bbefde6 to
72d9d50
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
72d9d50 to
88967e6
Compare
yhmtsai
added
1:ST:ready-for-review
yhmtsai
force-pushed
the
half_factorization
branch
from
88967e6 to
e667ec0
Compare
yhmtsai
force-pushed
the
half_solver
branch
2 times, most recently
from
50ae4c1 to
bba40e0
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
e667ec0 to
c32201d
Compare
MarcelKoch
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Generally LGTM. I have a question regarding atomics and hip. The latest ROCm shows support for fp16 atomic operations: https://rocm.docs.amd.com/en/latest/reference/precision-support.html#atomic-operations-support, but TBH I can't figure out what operations exactly they mean with that. Did you try anything in that regard?
| PairTypenameNameGenerator); | ||
|
|
||
|
|
||
| TYPED_TEST(ParIlut, KernelThresholdSelectIsEquivalentToRef) | ||
| { | ||
| using value_type = typename TestFixture::value_type; |
There was a problem hiding this comment.
Many of the tests here are missing SKIP_HALF if compiling for HIP.
There was a problem hiding this comment.
we do not support compute_l_u_factors in hip, but the others still works with half precision in HIP
cuda/solver/common_trs_kernels.cuh
Outdated
| @@ -212,13 +212,15 @@ struct CudaSolveStruct : gko::solver::SolveStruct { | |||
|
|
|||
| size_type work_size{}; | |||
|
|
|||
| // TODO: In nullptr is considered nullptr_t not casted to const | |||
| // it does not work in cuda110/100 images | |||
There was a problem hiding this comment.
nit:
Suggested change
| // it does not work in cuda110/100 images | |
| // Explicitly cast `nullptr` to `const ValueType*` to prevent compiler issues with cuda 10/11 |
There was a problem hiding this comment.
I think it is more on the host compiler side because it goes through our binding first with specfic type
yhmtsai
force-pushed
the
half_factorization
branch
from
f758d41 to
4b54a9d
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
4b54a9d to
f8a9b1c
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
f8a9b1c to
29239b3
Compare
yhmtsai
force-pushed
the
half_factorization
branch
2 times, most recently
from
d66627a to
b58712a
Compare
yhmtsai
force-pushed
the
half_solver
branch
2 times, most recently
from
3a98c11 to
ac216bc
Compare
yhmtsai
force-pushed
the
half_factorization
branch
from
b58712a to
53a1d80
Compare
yhmtsai
added
1:ST:ready-to-merge
… in shared memory
yhmtsai
force-pushed
the
half_factorization
branch
from
53a1d80 to
e0e42b0
Compare
|
Error: PR already merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds the factorization with half support.
Hip does not support atomic on the 16bits type currently
NVHPC 23.3 seems to handle assignment index with optimization wrongly on a custom class when IndexType is long. We set the index explicitly with volatile to solve it. NVHPC24.1 seem to fixed this issue.
https://godbolt.org/z/srYhGndKn
TODO: