Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squeeze memory dispatch code #1703

Merged
merged 1 commit into from
Oct 22, 2024
Merged

squeeze memory dispatch code #1703

merged 1 commit into from
Oct 22, 2024

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Oct 21, 2024

This PR squeezes the dispatch code in memory. It is done in #1257 by @MarcelKoch.
I extract them here and ensure it is good to change or not.

@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Oct 21, 2024
@yhmtsai yhmtsai requested review from upsj and MarcelKoch October 21, 2024 09:13
@yhmtsai yhmtsai self-assigned this Oct 21, 2024
@ginkgo-bot ginkgo-bot added mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:helper-scripts This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo. labels Oct 21, 2024
upsj
upsj approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MarcelKoch
MarcelKoch reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I originally wrote this, I won't review it. I just wanted to confirm that this is the change I intended to make.

@yhmtsai
Copy link
Member Author

yhmtsai commented Oct 21, 2024

I also go through it, so @MarcelKoch maybe approves it on my behalf?

MarcelKoch
MarcelKoch approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yhmtsai That makes sense.

@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. 1:ST:no-changelog-entry Skip the wiki check for changelog update and removed 1:ST:ready-for-review This PR is ready for review labels Oct 21, 2024
@yhmtsai @MarcelKoch
squeeze memory dispatch
bf70a4f 
Co-authored-by: Marcel Koch <[email protected]>
@yhmtsai yhmtsai force-pushed the squeeze_memory_dispatch branch from 6b557b8 to bf70a4f Compare October 22, 2024 09:54
@yhmtsai yhmtsai merged commit 42c86cd into develop Oct 22, 2024
8 of 11 checks passed
@yhmtsai yhmtsai deleted the squeeze_memory_dispatch branch October 22, 2024 12:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MarcelKoch pushed a commit to MarcelKoch/ginkgo that referenced this pull request Dec 2, 2024
@yhmtsai @MarcelKoch
Merge ginkgo-project#1703 squeeze memory dispatch code
62bc0c7 
This PR squeezes the memory dispatch code

Related PR: ginkgo-project#1703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@upsj upsj upsj approved these changes

Assignees

@yhmtsai yhmtsai

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:helper-scripts This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yhmtsai @upsj @MarcelKoch @ginkgo-bot