Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calamares: Explicitly set /etc/vconsole.conf font #4770

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ermo
Copy link
Contributor

@ermo ermo commented Jan 8, 2025

Summary
As part of the CBM changes in CBM PR 7, CBM will now parse the system /etc/vconsole.conf file and explicitly set the corresponding

rd.vconsole.font=(...) rd.vconsole.keymap=(...)

options on the kernel commandline, such that they are used in rescue initrd shells.

To make it clearer and more discoverable to the user what these variables are currently set to in the root fs, the present change ensures that, on new installs, the Solus default font selection of the terminus 32px bold console font with unicode support (ter-v32b), will now also be explicitly listed on the kernel command line for troubleshooting/rescue purposes via CBM.

This is primarily an ergonomics change meant to help Solus users understand how to influence these settings in the face of error modes that prevent them from logging in via their normal graphical session.

The consensus seemed to be that this PR ought to be followed up by a Documentation PR on the help center, expanding on the options between which the user can choose in terms of font sizes, font styles, and keyboard mappings, should they need to change the settings for whatever reason.

Test Plan

N/A (covered by CBM PR)

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

@ermo
Copy link
Contributor Author

ermo commented Jan 10, 2025

@EbonJaeger @silkeh The wise move here is probably for the two of you to coordinate the landing of the CBM + Calamares stuff?

Feel free to commandeer this PR. I only put it up in the spirit of showing my view on how we might approach the "make the boot-time experience for LUKS users and people troubleshooting a little more ergonomic." to Silke after the discussion the other day.

@ermo ermo requested review from silkeh and EbonJaeger January 10, 2025 02:49
@silkeh silkeh self-assigned this Jan 10, 2025
@silkeh silkeh force-pushed the calamares-set-etc-vconsole.conf-font-by-default branch from 177b205 to 33832c7 Compare January 16, 2025 21:12
@silkeh
Copy link
Member

silkeh commented Jan 16, 2025

Result on a clean install:

afbeelding

@silkeh silkeh removed their request for review January 16, 2025 21:35
@silkeh silkeh marked this pull request as ready for review January 16, 2025 21:36
ermo and others added 2 commits January 16, 2025 22:38
**Summary**
As part of the CBM changes in [1], CBM will now parse the system
`/etc/vconsole.conf` file and explicitly set the corresponding

`rd.vconsole.font=(...) rd.vconsole.keymap=(...)`

options on the kernel commandline, such that they are used in rescue
initrd shells.

[1]: getsolus/clr-boot-manager#7

To make it clearer and more discoverable to the user what these variables
are currently set to in the root fs, the present change ensures that the
Solus default font selection of the terminus 32px bold console font with
unicode support (ter-v32b), will now also be explicitly listed on the
kernel command line for troubleshooting/rescue purposes via CBM.

This is primarily an ergonomics change meant to help Solus users
understand how to influence these settings in the face of error modes
that prevent them from logging in via their normal graphical session.

The consensus seemed to be that this PR ought to be followed up by a
Documentation PR on the help center, expanding on the options between
which the user can choose in terms of font sizes, font styles, and
keyboard mappings, should they need to change the settings for whatever
reason.

Signed-off-by: Rune Morling <[email protected]>
@silkeh silkeh force-pushed the calamares-set-etc-vconsole.conf-font-by-default branch from 33832c7 to c6cc84f Compare January 16, 2025 21:38
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@silkeh silkeh merged commit ddb0470 into main Jan 16, 2025
1 check passed
@ermo ermo deleted the calamares-set-etc-vconsole.conf-font-by-default branch January 16, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants