feat: Add platforms to events and frames #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `platform` values to all stack frame and symbolication request types and endpoints. We're intentionally using `Platform` everywhere instead of the more narrow types appropriate to native, JS, or JVM, just in case Sentry sends an unexpected value.
jjbayer
approved these changes
Nov 28, 2024
|
Exactly. Before we implement any new behavior, I want Sentry to just send these platform values and make sure we can actually use them to base decisions on. |
Swatinem
approved these changes
Nov 28, 2024
| @@ -38,6 +38,7 @@ impl ConfigureScope for SymbolicationRequestQueryParams { | |||
| /// JSON body of the symbolication request. | |||
| #[derive(Serialize, Deserialize)] | |||
| pub struct SymbolicationRequestBody { | |||
| pub platform: Option<Platform>, | |||
There was a problem hiding this comment.
I believe this should also have a #[serde(default)]?
There was a problem hiding this comment.
#[serde(default)] is already implied for Option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
platformvalues to all stack frame and symbolication request types and endpoints.We're intentionally using
Platformeverywhere instead of the more narrow types appropriate to native, JS, or JVM, just in case Sentry sends an unexpected value.