feat(devservices): Add devservices config #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWoodard
approved these changes
Nov 27, 2024
Comment on lines
+7
to
+10
| # explicitly disable caches as it's not something we want in tests. in | ||
| # development it may be less ideal. perhaps we should do the same thing as we | ||
| # do with relay one day (one container per test/session), although that will be | ||
| # slow |
There was a problem hiding this comment.
Is this something we should revisit now?
There was a problem hiding this comment.
I think this is fine as it is. When developing Symbolicator you can just use a different config.
loewenheim
approved these changes
Nov 28, 2024
Comment on lines
+7
to
+10
| # explicitly disable caches as it's not something we want in tests. in | ||
| # development it may be less ideal. perhaps we should do the same thing as we | ||
| # do with relay one day (one container per test/session), although that will be | ||
| # slow |
There was a problem hiding this comment.
I think this is fine as it is. When developing Symbolicator you can just use a different config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config will control how symbolicator is brought up