ref(proguard): Properly size the in-memory cache #1424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, in-memory caches have a size of 100KiB. This is sufficient for file types where we only cache some bookkeeping structs in memory. In the case of Proguard, we cache
ProguardMapper
structs, and those can be quite hefty. In brief experiments I found a mapper to be slightly less than twice the size of the mapping file on disk, and those files can take up hundreds of megabytes.Therefore:
ProguardMapper
as twice the size of the file on disk;