-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ThreadLocal
metrics aggregator
#1379
Conversation
dce41b7
to
be4c89b
Compare
I finished implementing this for all the metrics types we are using, meaning counter, gauge and distribution-like. The results running
So this is a 50% improvement over using For all the "distribution-like" metrics, we currently keep all the individual values, but we send them as batches. We could instead calculate the distribution and percentiles locally and avoid that, whereby potentially improving things further. |
Thus far, this only works for `count` metrics, but we can extend it in the future as well.
bcb4aea
to
1f279bb
Compare
Thus far, this only works for
count
metrics, but we can extend it in the future as well.I would still call this pretty WIP for now. Ideally, I might extract all this metrics business into its own crate, or move it into the SDK crate.