Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase percentage of sampled transactions #1376

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem requested a review from a team February 16, 2024 12:04
@Swatinem Swatinem self-assigned this Feb 16, 2024
@Swatinem Swatinem enabled auto-merge (squash) February 16, 2024 12:07
Copy link
Contributor

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation?

@Swatinem Swatinem merged commit 4ae4745 into master Feb 16, 2024
10 checks passed
@Swatinem Swatinem deleted the swatinem/sample-trx branch February 16, 2024 12:12
@Swatinem
Copy link
Member Author

What is the motivation?

just because, no reason in particular.

I didn’t remember that we had such a low sample rate, I thought we were sampling a ton more transactions. I’m trying to figure out the overhead of all this instrumentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants