Update dependencies and silence errors #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since basically forever, `rust-minidump` has been spewing unactionable warnings related to `XSTATE` which are being logged as Sentry breadcrumbs. Also, a ton of S3 related `NoSuchBucket` errors have been logged internally which should ideally have been handled silently, but it looks like the S3 SDK does not properly handle those errors itself.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1370 +/- ##
==========================================
- Coverage 76.11% 76.09% -0.03%
==========================================
Files 101 101
Lines 15258 15262 +4
==========================================
- Hits 11614 11613 -1
- Misses 3644 3649 +5 |
loewenheim
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since basically forever,
rust-minidumphas been spewing unactionable warnings related toXSTATEwhich are being logged as Sentry breadcrumbs.Also, a ton of S3 related
NoSuchBucketerrors have been logged internally which should ideally have been handled silently, but it looks like the S3 SDK does not properly handle those errors itself.#skip-changelog