Do not persist SourceMap contents in FileInBundleCache
#1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Feb 5, 2024
According to metrics, the cache is quite effective in ST and on LPQ instances. Less so in production, most likely because the cache is too small. To increase the effective size of the cache, we do not store the actual sourcemap contents in it anymore. These contents are only used for sourcemapcache generation, and are not usually required.
When we got a file from the cache, we were not properly recording this metric.
anonrig
reviewed
Feb 6, 2024
Swatinem
force-pushed
the
swatinem/lazy-bundle-sourcemap
branch
from
c47708c to
a8ee1cf
Compare
Swatinem
force-pushed
the
swatinem/lazy-bundle-sourcemap
branch
from
a8ee1cf to
3498cec
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1359 +/- ##
==========================================
- Coverage 75.99% 75.75% -0.25%
==========================================
Files 100 101 +1
Lines 14835 14946 +111
==========================================
+ Hits 11274 11322 +48
- Misses 3561 3624 +63 |
loewenheim
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to metrics, the cache is quite effective in ST and on LPQ instances. Less so in production, most likely because the cache is too small.
To increase the effective size of the cache, we do not store the actual sourcemap contents in it anymore. These contents are only used for sourcemapcache generation, and are not usually required.
#skip-changelog