Remove scrape_js_file transaction
#1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Feb 2, 2024
We added this at one point to look at the `host`, but I doubt noone ever did this, or not in any recent history. Overhead from this should be negligible, but no code is still faster than fast code :-D
Swatinem
force-pushed
the
swatinem/rm-scrape-trx
branch
from
781905e to
ec66825
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
=======================================
Coverage 75.99% 75.99%
=======================================
Files 100 100
Lines 14846 14835 -11
=======================================
- Hits 11282 11274 -8
+ Misses 3564 3561 -3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this at one point to look at the
host, but I doubt noone ever did this, or not in any recent history.Overhead from this should be negligible, but no code is still faster than fast code :-D
#skip-changelog, because ofc