Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add symbolicate-js endpoint documentation #1208

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Jun 6, 2023

@kamilogorek kamilogorek requested a review from a team June 6, 2023 09:30
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1208 (39dcaa9) into master (591b020) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
+ Coverage   75.26%   75.34%   +0.08%     
==========================================
  Files          87       87              
  Lines       13823    13849      +26     
==========================================
+ Hits        10404    10435      +31     
+ Misses       3419     3414       -5     

Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits :)

docs/api/sourcemaps.md Outdated Show resolved Hide resolved
were loaded during JS code execution. The list is handled by the Sentry source.
- `stacktrace`: A list of stacktraces to symbolicate.
- `frames`: A list of frames with corresponding `abs_path`, `lineno`,
and `colno`, as well as minified `function` name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking colno is optional.

docs/index.md Outdated Show resolved Hide resolved
docs/api/sourcemaps.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Zivota <[email protected]>
@kamilogorek kamilogorek enabled auto-merge (squash) June 6, 2023 11:05
@kamilogorek kamilogorek requested a review from loewenheim June 6, 2023 11:21
@kamilogorek kamilogorek merged commit 20a8c26 into master Jun 6, 2023
@kamilogorek kamilogorek deleted the symbolicate-js-docs branch June 6, 2023 11:26
Copy link
Contributor

Fails
🚫

The snapshot directory has moved to a new location. Please update SNAPSHOT_LOCATION in /dangerfile.js.

Generated by 🚫 dangerJS against 39dcaa9

@kamilogorek
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants