Skip to content

Commit

Permalink
Revert "ref(proguard): Return raw stacktraces (#1399)" (#1401)
Browse files Browse the repository at this point in the history
This reverts commit 6d6163b.

As pointed out in the discussion of #1399, adding source context to the raw (obfuscated) stacktrace is not really useful. That makes returning the raw stacktrace pointless.
  • Loading branch information
loewenheim authored Mar 6, 2024
1 parent e931d57 commit 289578c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 0 additions & 2 deletions crates/symbolicator-proguard/src/interface.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ pub struct CompletedJvmSymbolicationResponse {
pub exceptions: Vec<JvmException>,
/// The stacktraces after remapping.
pub stacktraces: Vec<JvmStacktrace>,
/// The original stacktraces, possibly enhanced with source context.
pub raw_stacktraces: Vec<JvmStacktrace>,
/// Errors that occurred during symbolication.
pub errors: Vec<ProguardError>,
}
5 changes: 1 addition & 4 deletions crates/symbolicator-proguard/src/symbolication.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ impl ProguardService {
.collect();

let remapped_stacktraces = stacktraces
.iter()
.into_iter()
.map(|raw_stacktrace| {
let remapped_frames = raw_stacktrace
.frames
Expand All @@ -83,9 +83,6 @@ impl ProguardService {
CompletedJvmSymbolicationResponse {
exceptions: remapped_exceptions,
stacktraces: remapped_stacktraces,
// This is pointless for now—it's just the original stacktraces.
// However, it will become relevant when we implement source context.
raw_stacktraces: stacktraces,
errors,
}
}
Expand Down

0 comments on commit 289578c

Please sign in to comment.