chore(eslint): Enable no-duplicate-enum-values and fix violations (#8…

…3544) Relying on automation to find any problems with this.
getsentry · Jan 15, 2025 · 05cf949 · 05cf949
1 parent 8cff0dc
commit 05cf949
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -408,7 +408,6 @@ export default typescript.config([
       // Recommended overrides
       '@typescript-eslint/ban-ts-comment': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-array-constructor': 'off', // TODO(ryan953): Fix violations and delete this line
-      '@typescript-eslint/no-duplicate-enum-values': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-empty-object-type': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-explicit-any': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-extra-non-null-assertion': 'off', // TODO(ryan953): Fix violations and delete this line

diff --git a/static/app/types/group.tsx b/static/app/types/group.tsx
@@ -137,7 +137,6 @@ export enum IssueTitle {
   PROFILE_JSON_DECODE_MAIN_THREAD = 'JSON Decoding on Main Thread',
   PROFILE_REGEX_MAIN_THREAD = 'Regex on Main Thread',
   PROFILE_FRAME_DROP = 'Frame Drop',
-  PROFILE_FRAME_DROP_EXPERIMENTAL = 'Frame Drop',
   PROFILE_FUNCTION_REGRESSION = 'Function Regression',
   PROFILE_FUNCTION_REGRESSION_EXPERIMENTAL = 'Function Duration Regression (Experimental)',
 
@@ -168,7 +167,7 @@ const ISSUE_TYPE_TO_ISSUE_TITLE = {
   profile_json_decode_main_thread: IssueTitle.PROFILE_JSON_DECODE_MAIN_THREAD,
   profile_regex_main_thread: IssueTitle.PROFILE_REGEX_MAIN_THREAD,
   profile_frame_drop: IssueTitle.PROFILE_FRAME_DROP,
-  profile_frame_drop_experimental: IssueTitle.PROFILE_FRAME_DROP_EXPERIMENTAL,
+  profile_frame_drop_experimental: IssueTitle.PROFILE_FRAME_DROP,
   profile_function_regression: IssueTitle.PROFILE_FUNCTION_REGRESSION,
   profile_function_regression_exp: IssueTitle.PROFILE_FUNCTION_REGRESSION_EXPERIMENTAL,
 

diff --git a/static/app/views/insights/cache/referrers.ts b/static/app/views/insights/cache/referrers.ts
@@ -10,6 +10,5 @@ export enum Referrer {
   SAMPLES_CACHE_TRANSACTION_DURATION_CHART = 'api.performance.cache.samples-cache-transaction-duration-chart',
   SAMPLES_CACHE_TRANSACTION_DURATION = 'api.performance.cache.samples-cache-transaction-duration',
   SAMPLES_CACHE_SPAN_SAMPLES = 'api.performance.cache.samples-cache-span-samples',
-  SAMPLES_CACHE_SPAN_SAMPLES_TRANSACTION_DURATION = 'api.performance.cache.samples-cache-span-samples',
   SAMPLES_CACHE_HIT_MISS_CHART = 'api.performance.cache.samples-cache-hit-miss-chart',
 }