Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(android): Extracts Android native initialization to standalone structures #4445

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ref(android): Extracts Android native initialization to standalone structures #4445

wants to merge 5 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jan 14, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Extracts Android native initialization to standalone structures

💡 Motivation and Context

Part of #3608

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 428.13 ms 418.76 ms -9.37 ms
Size 17.75 MiB 20.11 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
83f6f6c 418.83 ms 410.94 ms -7.89 ms
8fe7c9d 437.52 ms 426.42 ms -11.10 ms
c639edf 466.48 ms 489.57 ms 23.09 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
d8e8c67 448.79 ms 438.70 ms -10.09 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
e540498 436.26 ms 433.00 ms -3.26 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
4297324 536.61 ms 542.48 ms 5.87 ms

App size

Revision Plain With Sentry Diff
83f6f6c 17.74 MiB 20.09 MiB 2.35 MiB
8fe7c9d 17.75 MiB 20.11 MiB 2.36 MiB
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
d8e8c67 17.74 MiB 20.10 MiB 2.36 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
e540498 17.73 MiB 20.11 MiB 2.37 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
4297324 17.74 MiB 20.08 MiB 2.34 MiB

Previous results on branch: antonis/extract-android-sdk-init

Startup times

Revision Plain With Sentry Diff
0b81196 501.00 ms 506.41 ms 5.41 ms

App size

Revision Plain With Sentry Diff
0b81196 17.75 MiB 20.11 MiB 2.37 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.41 ms 1219.76 ms 7.35 ms
Size 2.63 MiB 3.69 MiB 1.05 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
ac41368+dirty 1226.65 ms 1237.90 ms 11.24 ms
9cab16b+dirty 1237.76 ms 1234.00 ms -3.76 ms
2ec71da+dirty 1225.85 ms 1231.57 ms 5.72 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
f54118b+dirty 1232.98 ms 1235.73 ms 2.76 ms
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms

App size

Revision Plain With Sentry Diff
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
ac41368+dirty 2.36 MiB 3.14 MiB 793.46 KiB
9cab16b+dirty 2.36 MiB 3.08 MiB 737.23 KiB
2ec71da+dirty 2.36 MiB 3.13 MiB 784.66 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
f54118b+dirty 2.36 MiB 3.10 MiB 757.51 KiB
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB

Previous results on branch: antonis/extract-android-sdk-init

Startup times

Revision Plain With Sentry Diff
0b81196+dirty 1239.04 ms 1239.41 ms 0.37 ms

App size

Revision Plain With Sentry Diff
0b81196+dirty 2.63 MiB 3.68 MiB 1.05 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.83 ms 1242.81 ms 7.98 ms
Size 3.19 MiB 4.25 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
ac41368+dirty 1226.69 ms 1229.96 ms 3.27 ms
9cab16b+dirty 1236.10 ms 1247.16 ms 11.06 ms
2ec71da+dirty 1230.29 ms 1239.50 ms 9.21 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
f54118b+dirty 1235.42 ms 1236.80 ms 1.38 ms
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms

App size

Revision Plain With Sentry Diff
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
ac41368+dirty 2.92 MiB 3.69 MiB 794.29 KiB
9cab16b+dirty 2.92 MiB 3.64 MiB 743.06 KiB
2ec71da+dirty 2.92 MiB 3.69 MiB 791.06 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
f54118b+dirty 2.92 MiB 3.67 MiB 770.05 KiB
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB

Previous results on branch: antonis/extract-android-sdk-init

Startup times

Revision Plain With Sentry Diff
0b81196+dirty 1228.43 ms 1234.00 ms 5.57 ms

App size

Revision Plain With Sentry Diff
0b81196+dirty 3.19 MiB 4.25 MiB 1.06 MiB

@antonis antonis marked this pull request as ready for review January 14, 2025 18:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 369.98 ms 389.00 ms 19.02 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4cc5c27+dirty 398.36 ms 452.50 ms 54.14 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
9282172+dirty 363.57 ms 399.78 ms 36.20 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms
13f280b+dirty 376.13 ms 406.41 ms 30.28 ms
75774ea+dirty 426.80 ms 455.43 ms 28.62 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
57448c5+dirty 397.05 ms 462.65 ms 65.60 ms

App size

Revision Plain With Sentry Diff
4cc5c27+dirty 7.15 MiB 8.22 MiB 1.07 MiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
9282172+dirty 7.15 MiB 8.37 MiB 1.22 MiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB
13f280b+dirty 7.15 MiB 8.35 MiB 1.20 MiB
75774ea+dirty 7.15 MiB 8.36 MiB 1.21 MiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
57448c5+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Previous results on branch: antonis/extract-android-sdk-init

Startup times

Revision Plain With Sentry Diff
0b81196+dirty 402.70 ms 452.38 ms 49.68 ms

App size

Revision Plain With Sentry Diff
0b81196+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@antonis antonis mentioned this pull request Jan 15, 2025
Open
10 tasks
lucas-zimerman
lucas-zimerman approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @lucas-zimerman