feat(relay): add view hierarchy scrubbing #4452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Litarnus
changed the title
# Conflicts: # Cargo.lock # relay-pii/Cargo.toml # relay-server/src/services/processor/attachment.rs # tests/integration/test_attachments.py
# Conflicts: # CHANGELOG.md
loewenheim
reviewed
Jan 17, 2025
jjbayer
reviewed
Jan 17, 2025
Comment on lines
+529
to
+530
| let mut deserializer_inner = Deserializer::from_slice(payload); | ||
| let deserializer = crate::transform::Deserializer::new(&mut deserializer_inner, visitor); |
There was a problem hiding this comment.
nit, to make it super explicit which deserializer is which:
Suggested change
| let mut deserializer_inner = Deserializer::from_slice(payload); | |
| let deserializer = crate::transform::Deserializer::new(&mut deserializer_inner, visitor); | |
| let mut deserializer_inner = serde_json::Deserializer::from_slice(payload); | |
| let deserializer = transform::Deserializer::new(&mut deserializer_inner, visitor); |
| @@ -49,6 +49,7 @@ use serde::de; | |||
| /// } | |||
| /// } | |||
| /// ``` | |||
| #[allow(missing_docs)] | |||
There was a problem hiding this comment.
Should we add some docs instead?
| scrub_view_hierarchy(item, config) | ||
| } else if item.attachment_type() == Some(&AttachmentType::Minidump) { | ||
| scrub_minidump(item, config) | ||
| } else if has_simple_attachment_selector(config) && item.ty() == &ItemType::Attachment { |
There was a problem hiding this comment.
nit
Suggested change
| } else if has_simple_attachment_selector(config) && item.ty() == &ItemType::Attachment { | |
| } else if item.ty() == &ItemType::Attachment && has_simple_attachment_selector(config) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit ViewHierarchy scrubbing to the attachment scrubbing process.
Most of the logic is taken from the current recording scrubbing because both are JSON files.