Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the next clickhouse versions we are targeting for upgrades #15

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Add the next clickhouse versions we are targeting for upgrades #15

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd98e18
Add the next clickhouse versions we are targeting for upgrades
lynnagara Oct 6, 2023
294b9ed
add arm64/v8
lynnagara Oct 6, 2023
eea8838
Merge remote-tracking branch 'origin/main' into add-next-clickhouse-v…
lynnagara Oct 10, 2023
3e874f8
run update
lynnagara Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from typing import Mapping
from typing import NamedTuple

ARCHS = frozenset(('amd64', 'arm64'))
ARCHS = frozenset(('amd64', 'arm64', 'arm64/v8'))

LIST = 'application/vnd.docker.distribution.manifest.list.v2+json'
SINGLE = 'application/vnd.docker.distribution.manifest.v2+json'
Expand Down Expand Up @@ -121,6 +121,23 @@ def update(self) -> Image:
'sha256:125d2ea49c298515c46784d202a2bd4dde05157c85a76517afc2567f262ab335', # noqa: E501
),
),
Image(
registry='registry-1.docker.io',
source='altinity/clickhouse-server',
tag='22.3.15.34.altinitystable',
digests=(
'sha256:5a67ec149acc13e3d87ed1e3b94b4ada6f0acdc75145724959bbd8c0a6f18410', # noqa: E501
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm these have arm images so I expect them to have two digests

Copy link
Member

@asottile-sentry asottile-sentry Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh can you add arm64/v8 to the ARCHS sequence and re-import these? it should pull in the other digests then

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i created this wrong. Or at least I did it manually - is there automation for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the script has a sync / update / etc. subcomand 👍

),
),
Image(
registry='registry-1.docker.io',
source='altinity/clickhouse-server',
tag='22.8.15.25.altinitystable',
digests=(
'sha256:99d52fc10915136234a3b902b16d53f0ee80cd4f9149064acc30c89e54d06cf9', # noqa: E501
'sha256:2935d3849fcdf3c9a24883522630758a6f017c7b48a252f6e54e8fc188ccd0cc', # noqa: E501
),
),
Image(
registry='registry-1.docker.io',
source='checkr/flagr',
Expand Down