Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Primevue #185

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Upgrade Primevue #185

wants to merge 35 commits into from

Conversation

sadiqkhoja
Copy link
Contributor

No description provided.

sadiqkhoja added 30 commits July 30, 2024 12:30
@sadiqkhoja
reset scroll in Demo app
a3ab39d
@sadiqkhoja
add new icons
9467b61
@sadiqkhoja
Feature getodk#130: Required and constraint validations
4a92320
@sadiqkhoja
Styling changes
02c309b
@sadiqkhoja
Refactor: use provide/inject for submitPressed.
6c062f7 
* Instead of using CSS for sharing the state between components, I have used provide/inject method.
* Using input and blur events to determine when to show validation message
* Created a separate validation message component and consumed it in components for ControlNodes instead of having it in FormQuestion component
@sadiqkhoja
Moved Form level error message out of FormHeader
2ce71eb
@sadiqkhoja
use inset-inline-end instead of right for positioning error icon insi…
29879d3 
…de textbox
@sadiqkhoja
set width of form error message to 100% for smaller screens
811b6ce
@sadiqkhoja
remove additional wrapper div that was added in .smaller-screen section
3b5b6f7
@sadiqkhoja
change unit of scroll-margin-top from px to rem
a2d4ec8
@sadiqkhoja
Scroll to first invalid question + focus it if it is a textbox
62c7859
@sadiqkhoja
fix: submitPressed not provided error
c555db4
@sadiqkhoja
fix: reduce heading size and weight
3bffb9d
@sadiqkhoja
fix: change background color of textboxes
8773137
@sadiqkhoja
fix: make width of language change to max-content
257d504
@sadiqkhoja
fix: reduce the spacing between questions in groups
ccd7673
@sadiqkhoja
fix: remove shadow from the cards
270a47c
@sadiqkhoja
fix: add + icon for repeat add button. Also fix vertical spacing for …
6f86943 
…repeats
@sadiqkhoja
fix: change the style of disabled textbox
68fe0c0
@sadiqkhoja
fix: flat the send button
564706a
@sadiqkhoja
fix: increase the size of repeat number
893ef04
@sadiqkhoja
fix: size and style of repeat context menu
661530c
@sadiqkhoja
fix: align hamburger to the top + show options based on container size
9c03ed5
@sadiqkhoja
fix: align chevron to the middle
b6abddc
@sadiqkhoja
fix: set background of the widget to white
b3d392c
@sadiqkhoja
fix: align question container when it is inside groups
0188fd1
@sadiqkhoja
fix: make fix-error a button
e21db60
@sadiqkhoja
fix: gap between label and control
d5cbf6f
@sadiqkhoja
format all
33301d1
@sadiqkhoja
Increase max-width of language changer and min-width of container query
d2bc54d
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: 3def368

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sadiqkhoja