Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint/required validation UI #164

Merged
merged 42 commits into from
Aug 20, 2024
Merged

Constraint/required validation UI #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
a3ab39d
reset scroll in Demo app
sadiqkhoja Jul 12, 2024
9467b61
add new icons
sadiqkhoja Jul 12, 2024
4a92320
Feature #130: Required and constraint validations
sadiqkhoja Jul 12, 2024
02c309b
Styling changes
sadiqkhoja Jul 15, 2024
6c062f7
Refactor: use provide/inject for submitPressed.
sadiqkhoja Jul 26, 2024
2ce71eb
Moved Form level error message out of FormHeader
sadiqkhoja Jul 26, 2024
29879d3
use inset-inline-end instead of right for positioning error icon insi…
sadiqkhoja Jul 26, 2024
811b6ce
set width of form error message to 100% for smaller screens
sadiqkhoja Jul 26, 2024
3b5b6f7
remove additional wrapper div that was added in .smaller-screen section
sadiqkhoja Jul 30, 2024
a2d4ec8
change unit of scroll-margin-top from px to rem
sadiqkhoja Jul 30, 2024
62c7859
Scroll to first invalid question + focus it if it is a textbox
sadiqkhoja Jul 30, 2024
c555db4
fix: submitPressed not provided error
sadiqkhoja Aug 2, 2024
3cd4ae9
fix socio-economic-survey fixture
sadiqkhoja Aug 13, 2024
0905461
added component tests
sadiqkhoja Aug 13, 2024
b27ad3c
Add todo tag for translations strings that are not in template
sadiqkhoja Aug 13, 2024
3962122
Remove fix-errors button
sadiqkhoja Aug 16, 2024
a74c439
fix: reduce heading size and weight
sadiqkhoja Jul 17, 2024
65b5795
fix: change background color of textboxes
sadiqkhoja Jul 17, 2024
d33bc91
fix: make width of language change to max-content
sadiqkhoja Jul 17, 2024
91444be
fix: reduce the spacing between questions in groups
sadiqkhoja Jul 17, 2024
2268948
fix: remove shadow from the cards
sadiqkhoja Jul 17, 2024
808b248
fix: add + icon for repeat add button. Also fix vertical spacing for …
sadiqkhoja Jul 17, 2024
a61fdc3
fix: change the style of disabled textbox
sadiqkhoja Jul 18, 2024
73f4eb1
fix: flat the send button
sadiqkhoja Jul 18, 2024
6be659c
fix: increase the size of repeat number
sadiqkhoja Jul 18, 2024
0d8cf11
fix: size and style of repeat context menu
sadiqkhoja Jul 18, 2024
019cdf6
fix: align hamburger to the top + show options based on container size
sadiqkhoja Jul 18, 2024
41e038a
fix: align chevron to the middle
sadiqkhoja Jul 18, 2024
7cbf6f3
fix: set background of the widget to white
sadiqkhoja Jul 18, 2024
db1fce3
fix: align question container when it is inside groups
sadiqkhoja Jul 18, 2024
cf99dfd
fix: gap between label and control
sadiqkhoja Jul 19, 2024
1f24590
format all
sadiqkhoja Jul 19, 2024
8310581
Increase max-width of language changer and min-width of container query
sadiqkhoja Jul 31, 2024
644de7c
set max-width of add repeat button to 260px
sadiqkhoja Jul 31, 2024
ba86b4d
remove .chevron padding and make h2(flex) items align center
sadiqkhoja Jul 31, 2024
1090b6b
use gap instead of margin between select options
sadiqkhoja Jul 31, 2024
dfd58ea
fix vertical alignment of validation message and no hover state for l…
sadiqkhoja Jul 31, 2024
0eda90d
fix vertical alignment of icon and text in add button of repeats
sadiqkhoja Aug 16, 2024
2d6f7cb
added comment for negative left margin
sadiqkhoja Aug 16, 2024
bb57e35
use document scrolling instead of window
sadiqkhoja Aug 19, 2024
3e5c027
use vitest for mocking document properties and element methods
sadiqkhoja Aug 19, 2024
82d35d0
Create changeset
sadiqkhoja Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/proud-elephants-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@getodk/ui-solid": patch
"@getodk/web-forms": minor
---

- Show message when required or other constrainst are not satisfied.
- Show error message banner at the top of the Form when "Send" button is pressed and the Form is invalid
- Various design/UI tweaks to beautify the Form
Loading