Select appearances #142
Select appearances #142
Conversation
🦋 Changeset detectedLatest commit: 508eab1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sadiqkhoja
force-pushed
the
features/select-appearances
branch
from
be1d6b2 to
ed8220d
Compare
* Implemented minimal, autocomplete, no-buttons, likert, list, list-nolabel, label, columns, column-pack, column-n for Select1 * Implemented minimal, autocomplete, no-buttons, list, list-nolabel, label, columns, column-pack, column-n for SelectN * Implementation of map and image-map appearances will be handled separately * Dynamic width of select options is achieved using javascript, we need to find a way to do it using css if possible * Original SelectControl.vue has been decomposed into Select1Control and SelectNControl. * Widgets directory contains low level components, mostly combination of a label and a primevue component * Appearance directory contains wrapper components to acheive desire UI layout
sadiqkhoja
force-pushed
the
features/select-appearances
branch
from
ed8220d to
2baf72a
Compare
There was a problem hiding this comment.
Overall looking really great! I'm excited to see the appearances in action, and they generally do what I expect as I interact with them. This really does make the overall product progress feel a lot more tangible!
As mentioned on a call the other day, I'm also thrilled to see some of the component organization coming into focus. I think it might be worth aligning naming/hierarchy/compositional concepts throughout ODK (design, overlap with Collect, docs). That might be a pretty big task, but it's feeling plausible with this progress, and I think it'll be worth it to have that kind of a holistic view.
I have made a few comments inline. Some are just questions. I have some concerns about the FullWidth directive, commented in detail there.
packages/web-forms/src/components/widgets/SearchableDropdown.vue
Outdated
Show resolved
Hide resolved
* Hover state for the likert option * Small gap between the options. Also added class to span of RadioButton and CheckboxWidget
sadiqkhoja
force-pushed
the
features/select-appearances
branch
from
3280c5e to
af5131c
Compare
sadiqkhoja
force-pushed
the
features/select-appearances
branch
from
16525f6 to
508eab1
Compare
Closes #141 and #86