Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #108: resolve existing eslint warnings #109

Merged
merged 2 commits into from
May 20, 2024
Merged

fixes #108: resolve existing eslint warnings #109

merged 2 commits into from
May 20, 2024

Conversation

sadiqkhoja
Copy link
Contributor

Closes #108

eyelidlessness
eyelidlessness requested changes May 15, 2024
View reviewed changes
Copy link
Member

@eyelidlessness eyelidlessness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few minor nits.

packages/xforms-engine/src/body/text/TextElementDefinition.ts Show resolved Hide resolved
packages/xpath/test/native/comparison-operator2.spec.ts Outdated Show resolved Hide resolved
packages/xpath/test/native/node-name.spec.ts Outdated Show resolved Hide resolved
@sadiqkhoja sadiqkhoja requested a review from eyelidlessness May 15, 2024 21:08
eyelidlessness
eyelidlessness approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@eyelidlessness eyelidlessness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sadiqkhoja sadiqkhoja merged commit ab7a23a into main May 20, 2024
71 checks passed
@sadiqkhoja sadiqkhoja deleted the fixes/108-lint branch May 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyelidlessness eyelidlessness eyelidlessness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve existing eslint warnings
2 participants
@sadiqkhoja @eyelidlessness