Merge pull request #171 from getodk/fix/select-violation-aggregation

Fix: reactive aggregation of validation violations from selects
getodk · Jul 17, 2024 · cfde5ea · cfde5ea
2 parents a933f6f + e81aa43
commit cfde5ea
Show file tree

Hide file tree

Showing 3 changed files with 435 additions and 159 deletions.
diff --git a/.changeset/breezy-sheep-play.md b/.changeset/breezy-sheep-play.md
@@ -0,0 +1,5 @@
+---
+'@getodk/xforms-engine': patch
+---
+
+Fix: reactive aggregation of validation violations from selects
diff --git a/packages/xforms-engine/src/instance/SelectField.ts b/packages/xforms-engine/src/instance/SelectField.ts
@@ -128,12 +128,7 @@ export class SelectField
 	}
 
 	getViolation(): AnyViolation | null {
-		// Read engine state to ensure reactivity in engine, Solid-based clients
-		this.validation.engineState.violation;
-
-		// Read/return client state to ensure client reactivity, regardless of
-		// client's reactive implementation
-		return this.validationState.violation;
+		return this.validation.engineState.violation;
 	}
 
 	protected getSelectItemsByValue(