Fixed deleting entities from lists with special characters #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Jan 14, 2025
grzesiek2010
force-pushed
the
COLLECT-6559
branch
from
d8a5328 to
d0fb959
Compare
Fixed. |
seadowg
reviewed
Jan 14, 2025
| repository.save("wines.x", leoville) | ||
| repository.save("wines-x", leoville) | ||
|
|
||
| repository.delete("1") |
There was a problem hiding this comment.
This makes me realize that delete should probably take a list as an arg as well, but that's for another time!
| @@ -198,7 +198,7 @@ class DatabaseEntitiesRepository(context: Context, dbPath: String) : EntitiesRep | |||
| databaseConnection.withConnection { | |||
| getLists().forEach { | |||
| writableDatabase.delete( | |||
| it, | |||
| "`$it`", | |||
There was a problem hiding this comment.
Is there a reason to use backticks here instead of quotes like in the rest of the file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6559
Why is this the best possible solution? Were any other approaches considered?
We need to quote the list name to make it possible to use special characters in table names in SQL. It's not the first issue like that so this approach is the same as it was before in the case of similar problems.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We’ve encountered issues with handling special characters in entities in other areas before, so this isn’t a new problem. Please test it as described in the issue (deleting entities), but keep in mind that this might not be the last case we’ll need to address.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with entities where lists contain special characters like
.or-.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest