Fixes #1047: preventDefault() #1122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
force-pushed
the
fixes/1047-dont-download-file-in-test
branch
2 times, most recently
from
dfb7ad6 to
124cbed
Compare
so we don't download the actual file
sadiqkhoja
force-pushed
the
fixes/1047-dont-download-file-in-test
branch
from
124cbed to
f09eaed
Compare
sadiqkhoja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1047
Builds are failing on the master branch as well, this fix is necessary now.
What has been done to verify that this works as intended?
All tests are passing and no file is created on the file system.
Why is this the best possible solution? Were any other approaches considered?
This solves the problem, but I am open to hearing other options. @matthew-white mentioned something about
preventDefaultin tests in the issue, I don't where to set that.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes