db-migrations: use pg for new migrations #1363
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
January 14, 2025 07:40
alxndrsn
commented
Jan 14, 2025
| } catch (err) { | ||
| console.error('Error:', err.message); | ||
| console.error(err); |
There was a problem hiding this comment.
Revert this change - it was just for debugging.
alxndrsn
commented
Jan 14, 2025
| @@ -28,10 +28,10 @@ NODE_CONFIG_DIR=../../config DEBUG=knex:query,knex:bindings npx knex migrate:up | |||
| */ | |||
|
|
|||
| const config = require('config'); | |||
| const { connectionObject } = require('../util/db'); | |||
| const { knexConfig } = require('../util/db'); | |||
There was a problem hiding this comment.
Create a separate PR for this.
alxndrsn
commented
Jan 14, 2025
| @@ -0,0 +1,23 @@ | |||
| // Copyright 2025 ODK Central Developers | |||
There was a problem hiding this comment.
This file is included for demo purposes - it will actually be included by #1356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/model/migrations/legacyto dissuade creating new knex-based migrationsTODO
connectionObjectrename (knex: rename connection object #1364)connectrenameWhat has been done to verify that this works as intended?
CI
Why is this the best possible solution? Were any other approaches considered?
Could use slonik instead, but seems better to tie implementation to a lower-level library, especially given concerns about upgrading to a more recent slonik (there are large API changes) and/or possibility of moving to an alternative to slonik.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Intended effects: none
Possible effects: break production databases
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Shouldn't require docs changes.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes