Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: catch .only() calls in db-migration tests #1360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Jan 14, 2025

Because db-migration tests use a wrapper for mocha describe() calls, extra configuration is required to catch .only() calls.

See: https://www.npmjs.com/package/eslint-plugin-no-only-tests#user-content-options

Issue discovered while working on #1355

What has been done to verify that this works as intended?

Tested locally while working on #1355.

Why is this the best possible solution? Were any other approaches considered?

It is consistent with current detection & rejection of .only() calls in other tests.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Only affects test code.

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

No.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

Because db-migration tests use a wrapper for mocha describe() calls, extra configuration is required to catch .only() calls.

See: https://www.npmjs.com/package/eslint-plugin-no-only-tests#user-content-options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant