Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/purge: resolve lint exceptions: no-shadow #1140

Merged
merged 1 commit into from
May 7, 2024
Merged

test/purge: resolve lint exceptions: no-shadow #1140

merged 1 commit into from
May 7, 2024

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented May 7, 2024

The logic as to when indentation should be increased isn't clear to me, but this removes lint exceptions with minimal change to surrounding code.

@alxndrsn alxndrsn requested a review from ktuite May 7, 2024 14:16
@alxndrsn alxndrsn merged commit d648d9d into getodk:master May 7, 2024
@alxndrsn alxndrsn deleted the test-task-purge-no-shadow branch May 7, 2024 20:28
matthew-white pushed a commit that referenced this pull request May 8, 2024
@alxndrsn @matthew-white
test/purge: resolve lint exceptions: no-shadow (#1140)
97b2172 
The logic as to when indentation should be increased isn't clear to me, but this removes lint exceptions with minimal change to surrounding code.
@matthew-white
Copy link
Member

matthew-white commented May 8, 2024 •
edited
Loading

This PR included a large binary file, so we decided to rewrite history and edit the merged commit. Doing so also modified the merged commits for #1138 and #1141. Those two were the only other PRs merged between when this PR was merged and when history was rewritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktuite ktuite ktuite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxndrsn @matthew-white @ktuite