Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonb concatenation in down migration #1091

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

matthew-white
Copy link
Member

While working on #1090, I took a look at how previous migrations had updated verbs. I noticed the use of the + operator in one migration, but later I realized that that's not actually a valid operator for the verbs column, which is jsonb. We use the || operator in other migrations, so I went ahead and replaced the + with ||. Clearly, the + wasn't actually causing any issues: we must never have needed to run the down migration. But it was a little confusing when I was trying to find prior related work and came across the operator.

What has been done to verify that this works as intended?

I didn't do anything to verify the change, since it seems clear that we've never needed to run the down migration. I just wanted to make the code a little clearer and more consistent with other migrations.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white requested a review from ktuite February 15, 2024 20:43
@matthew-white matthew-white merged commit 536f4e0 into master Feb 16, 2024
5 checks passed
@matthew-white matthew-white deleted the jsonb-concat branch February 16, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants