Fix jsonb concatenation in down migration #1091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1090, I took a look at how previous migrations had updated verbs. I noticed the use of the
+
operator in one migration, but later I realized that that's not actually a valid operator for theverbs
column, which isjsonb
. We use the||
operator in other migrations, so I went ahead and replaced the+
with||
. Clearly, the+
wasn't actually causing any issues: we must never have needed to run the down migration. But it was a little confusing when I was trying to find prior related work and came across the operator.What has been done to verify that this works as intended?
I didn't do anything to verify the change, since it seems clear that we've never needed to run the down migration. I just wanted to make the code a little clearer and more consistent with other migrations.
Before submitting this PR, please make sure you have:
make test
and confirmed all checks still pass OR confirm CircleCI build passes