Skip to content

Commit

Permalink
Misc fixes for oss (facebookresearch#134)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookresearch#134

X-link: facebookresearch/vrs#168

- fmt::join has been moved in the fmt library from one header to another. We need to include both location to be sure to build in all context and in open source with older and newer versions of fmt.
- make sure the vrs hash is current
- remove some fb-only includes

Differential Revision: D66797878
  • Loading branch information
Georges Berenger authored and facebook-github-bot committed Dec 5, 2024
1 parent baaef19 commit 7ac4a69
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
1 change: 1 addition & 0 deletions csrc/reader/MultiVRSReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <string>

#include <fmt/format.h>
#include <fmt/ranges.h>

#include <pybind11/attr.h>
#include <pybind11/cast.h>
Expand Down
2 changes: 1 addition & 1 deletion csrc/vrs
Submodule vrs updated from 6add55 to e021ba
4 changes: 0 additions & 4 deletions csrc/writer/VRSWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
#define DEFAULT_LOG_CHANNEL "VRSWriter"
#include <logging/Log.h>

#include <vrs/gaia/GaiaClient.h>
#include <vrs/gaia/GaiaUploader.h>
#include <vrs/gaia/UploadMetadata.h>

#include "../VrsBindings.h"
#include "../utils/PyUtils.h"
#include "StreamFactory.h"
Expand Down

0 comments on commit 7ac4a69

Please sign in to comment.