Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOR: docker compose for MAINNET#55 #56

Merged
merged 3 commits into from
Dec 15, 2023
Merged

SOR: docker compose for MAINNET#55 #56

merged 3 commits into from
Dec 15, 2023

Conversation

4TT1L4
Copy link
Contributor

@4TT1L4 4TT1L4 commented Dec 11, 2023 •
edited
Loading

Summary

Changed the network config of the docker compose to be configurable and not hard-coded to preprod.

Related to:

Type of Change

  • New feature (non-breaking change which adds functionality)

Testing

  • The node starts and no errors are logged.

Additional Information

docker compose up 
docker compose up --env NETWORK=preprod

@4TT1L4 4TT1L4 requested a review from a team as a code owner December 11, 2023 09:25
@4TT1L4 4TT1L4 requested a review from HalukG December 11, 2023 09:25
@4TT1L4 4TT1L4 self-assigned this Dec 11, 2023
@4TT1L4 4TT1L4 added T-Shirt size - Medium High-Level effort estimation. Category "medium effort". Task A feature request or general task involving code changes. Priority - High Issue has high priority and has to be worked, if no blocker issues are being worked on. labels Dec 11, 2023
@4TT1L4 4TT1L4 changed the title SOR: docker compose for MAINNET#172 SOR: docker compose for MAINNET#53 Dec 11, 2023
@4TT1L4 4TT1L4 changed the title SOR: docker compose for MAINNET#53 SOR: docker compose for MAINNET#55 Dec 11, 2023
Micrograx
Micrograx previously approved these changes Dec 14, 2023
View reviewed changes
sourabhxyz
sourabhxyz previously approved these changes Dec 14, 2023
View reviewed changes
@Micrograx Micrograx dismissed stale reviews from sourabhxyz and themself via ce7ab38 December 14, 2023 20:00
@4TT1L4 4TT1L4 merged commit d492d01 into main Dec 15, 2023
1 check passed
@sourabhxyz sourabhxyz deleted the 55-sor-docker-compose-for-mainnet branch December 15, 2023 08:27
@4TT1L4 4TT1L4 mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourabhxyz sourabhxyz sourabhxyz approved these changes

@HalukG HalukG Awaiting requested review from HalukG

@Micrograx Micrograx Awaiting requested review from Micrograx

Assignees

@4TT1L4 4TT1L4

Labels
Priority - High Issue has high priority and has to be worked, if no blocker issues are being worked on. T-Shirt size - Medium High-Level effort estimation. Category "medium effort". Task A feature request or general task involving code changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4TT1L4 @Micrograx @sourabhxyz