-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ethexe-tx-pool): Introduce basic tx-pool #4366
Open
techraed
wants to merge
19
commits into
master
Choose a base branch
from
st-tx-pool-ethexe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techraed
commented
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after review call
… tx pool for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a basic logic for the ethexe tx pool which works as following:
InputTask
is a task that is requested to be executed by the tx pool. The task is sent viaTxPoolInputTaskSender
sending end of the channel between the sender and the tx pool service. The sendind end is supplied to the main service and the rpc.InputTask
and calls corresponding tx pool core method to handle the task.InputTask::AddTransaction
task triggers tx pool core to 1) validate the transaction, 2) store it in dbInputTask::AddTransaction
is executed successfully the tx pool services sendsOutputTask::PropogateTransaction
to the main service.OutputTask::PropogateTransaction
by gossiping it to other nodes.InputTask::AddTransaction
task and sends it to the tx pool. If tx exists, it's not added to the storage.Here you can also find a tiny refactoring of the
ethexe-signer
which is all about clarifying comments, simplified API and moving types to their own modules.UPD
Changes in #4427 related to this PR
TxPoolTrait
,TxPoolCore
Transaction
trait is heavily changedEthexeTransaction
is changed, as all transactions.UPD
#4427 merged into this PR