Updating filtercache with exception handler to log errors and not cra…

…sh; added further checks
gawati · Apr 20, 2018 · be0e867 · be0e867
1 parent e58c9ad
commit be0e867
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 11 deletions.
diff --git a/filtercache.js b/filtercache.js
@@ -255,16 +255,21 @@ function remapKeyWords(filterValue) {
     const KW = "keyword";
     const KW_THRESHOLD = 50; 
     var filterMap = pick(filterValue, ["name", "label"]);
-    if(!apputils.objectIsEmpty(filterMap)) {
-        if (filterValue[KW].length <= KW_THRESHOLD) {
-            filterMap[KW] = filterValue[KW];
-        } else {
-            filterMap[KW] = apputils.randomNItemsFromArray(
-                filterValue[KW], 
-                KW_THRESHOLD
-            );
+    try {
+        if(!apputils.objectIsEmpty(filterValue)) {
+            if (filterValue.hasOwnProperty(KW)) {
+                if (filterValue[KW].length <= KW_THRESHOLD) {
+                    filterMap[KW] = filterValue[KW];
+                } else {
+                    filterMap[KW] = apputils.randomNItemsFromArray(
+                        filterValue[KW], 
+                        KW_THRESHOLD
+                    );
+                }
+            }
         }
-
+    } catch (error) {
+        logr.error("Exception in remapKeywords ", error);
     }
     return filterMap;
 }