Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checking for propagate kwargs. #133

Open
wants to merge 1 commit into
base: ag-propagatebind
Choose a base branch
from

Conversation

GuusAvis
Copy link

@GuusAvis GuusAvis commented Aug 5, 2024

Added type testing for some kwargs in propagate, and adjusted a test that I think was already failing because of a wrong type but now it no longer fails quietly.

This is basically the same as #126, but applied to the changes of #132 (where an extra kwarg was introduced) and with a fix of the test.

Unfortunately is seems that the changes are triggering the failing of some other tests. I think the problem is that now, in case keep_deltas isa Val{true} but keep_triples isa Val{false}, propagate sometimes returns a Dual type instead of a StochasticTriple type. The test expects the latter though. I'm not entirely sure what the intended behavior is though so I won't make any further changes without further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant