Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker::run): add the enable param #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reppard
Copy link

@reppard reppard commented Apr 25, 2016

Here is a possible answer to #308. All tests passing with the exception of one unrelated beaker test. I confirmed that this test is failing sans this code change.

spec/acceptance/docker_spec.rb:114 # docker registry should be able to login to the registry

Example:

docker::run { 'seagull':
  image         => 'tobegit3hub/seagull:1.3.0',
  ports         => ['10086:10086'],
  volumes       => ['/var/run/docker.sock:/var/run/docker.sock'],
  enable        => true,
  running       => false,
  pull_on_start => true,
  require       => Class['docker'],
}

This would allow us to enable services without starting the service or pulling the images down until a reboot or the services are manually triggered. This is useful for baking things like Vagrant boxes and AMIs.

Whether or not this can be merged, feedback would be greatly appreciated! I would be happy to make suggested changes and update the PR so we can get this functionality added to the module.

Thanks for the great work.

  • Reppard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants