GTN-tutorials-for-neoantigen #5467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workflow in progress
edited the flow of the non normal
shiltemann
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Thank @subinamehta!
Seven new tutorials, wow! I have left some small comments below, but overall this looks great!
I already implemented most of my own comments since I know you would like to publish this with your paper soon, so please just double-check my changes and feel free to undo if you don't agree with certain things.
A couple things still TODO for you as well but hopefully not so much.
topics/proteomics/tutorials/neoantigen-1-fusion-database-generation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-1-fusion-database-generation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-1-fusion-database-generation/tutorial.md
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-2-non-normal-database-generation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-2-non-normal-database-generation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-2-non-normal-database-generation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-3-fragpipe-discovery/tutorial.md
Outdated
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-4-peptide-verification/tutorial.md
Outdated
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-5-variant-annotation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/proteomics/tutorials/neoantigen-7-hla-binding-novel-peptides/tutorial.md
Show resolved
Hide resolved
…eneration/tutorial.md Co-authored-by: Saskia Hiltemann <[email protected]>
shiltemann
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
@subinamehta Thanks for the revisions! I am merging this now, and you can add the workflow tests in a follow-up PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow in progress
TODO: Describe your changes here..