Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tutorial on trajectory analysis #4367

Merged
merged 34 commits into from
Dec 8, 2023
Merged

Conversation

MarisaJL
Copy link
Collaborator

This is mostly a copy of the existing Jupyter version of this tutorial.

@MarisaJL MarisaJL requested a review from a team as a code owner September 28, 2023 18:44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I left an empty file there by mistake!

@hexylena
Copy link
Member

hexylena commented Oct 6, 2023

The accessibility linting errors will be fixed shortly in main, so no worries there. However the workflow is missing a test case

This workflow is missing a test, which is now mandatory. Please see the FAQ on how to add tests to your workflows.

@MarisaJL
Copy link
Collaborator Author

MarisaJL commented Oct 6, 2023

The accessibility linting errors will be fixed shortly in main, so no worries there. However the workflow is missing a test case

This workflow is missing a test, which is now mandatory. Please see the FAQ on how to add tests to your workflows.

Thanks - I'm going to try and do the workflow tests!

@wm75
Copy link
Contributor

wm75 commented Oct 6, 2023

@MarisaJL This workflow test does not test the contents of outputs, which is now mandatory. so you do need to populate the outputs section of the tests, sorry.
https://github.com/galaxyproject/training-material/blob/main/topics/variant-analysis/tutorials/pox-tiled-amplicon/workflows/pox-virus-tiled-amplicon-ref-masking-test.yml is an example how you can do this with checksums.

@hexylena
Copy link
Member

hexylena commented Nov 2, 2023

Thanks so much for your patience with all the workflow testing changes @MarisaJL hopefully we'll be able to soon turn this into automated histories across the usegalaxy.* servers.

hexylena
hexylena previously approved these changes Nov 2, 2023
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! made a couple small comments but from the gtn/formatting side this looks great

> >
> > 1. The interesting change here is that our DP-M4 cells are now heading on a clear trajectory towards differentiation. It looks like we've got the correct ordering of cells from DN through the DP groups and on towards T-mature. We didn't see this in our previous plots.
> >
> > ![The M4 cluster is now closer to the DP L cluster](../../images/scrna-case_trajectories/TrajectoriesFDG3.png "FDG plot initiated from the PAGA plot")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fantastic alt text, short and tells the reader exactly what they should be getting out of this graphic.

@hexylena
Copy link
Member

hexylena commented Nov 2, 2023

The validation failures are due to things I caused, which were fixed in #4476 and can be ignored :)

Thanks for your help!

Co-authored-by: Helena <[email protected]>
@hexylena
Copy link
Member

hexylena commented Nov 2, 2023

@nomadscientist ready from my side if ok for you

Copy link
Collaborator

@mtekman mtekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, I love the content.

I have a few nitpicking points about explaining some acronyms -- but feel free to ignore them if you believe that users would already be aware of what these acronyms mean at this point in the galaxy tutorials.

Copy link
Member

@pavanvidem pavanvidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easy to follow. Well done! I tried the tutorial with 1.8.1+galaxy9 and worked. With the latest version it fails but that's ok I guess because we have links to specific tool version.

pavanvidem
pavanvidem previously approved these changes Dec 7, 2023
@mtekman
Copy link
Collaborator

mtekman commented Dec 7, 2023

Let me add my changes, and we can maybe merge this today?

Copy link
Collaborator

@mtekman mtekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I turned my comments into commits


## Re-draw force-directed graph (again!)

Force directed graphs can be initialised randomly, or we can prod it in the right direction. We'll prod it with our PAGA calculations. Note that you could also try prodding it with tSNE or UMAP. A lot of these tools can be used on top of each other or with each other in different ways, this tutorial is just one example. Similarly, you could be using any **obs** information for grouping, so could do this for *louvain* or *cell_type* for instance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Force directed graphs can be initialised randomly, or we can prod it in the right direction. We'll prod it with our PAGA calculations. Note that you could also try prodding it with tSNE or UMAP. A lot of these tools can be used on top of each other or with each other in different ways, this tutorial is just one example. Similarly, you could be using any **obs** information for grouping, so could do this for *louvain* or *cell_type* for instance.
Force directed graphs can be initialised randomly, or we can prod it in the right direction. We'll prod it with our PAGA calculations. Note that you could also try prodding it with [tSNE](https://en.wikipedia.org/wiki/T-distributed_stochastic_neighbor_embedding) or [UMAP](https://en.wikipedia.org/wiki/Nonlinear_dimensionality_reduction#Uniform_manifold_approximation_and_projection). A lot of these tools can be used on top of each other or with each other in different ways, this tutorial is just one example. Similarly, you could be using any **obs** information for grouping, so could do this for *louvain* or *cell_type* for instance.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two wikipedia links, but maybe not necessary.

@pavanvidem pavanvidem merged commit dbcf86c into galaxyproject:main Dec 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants