-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deeparg #6646
base: main
Are you sure you want to change the base?
Add deeparg #6646
Conversation
…ly for test, modify loc file
Problem when using deepARG in a container with the Theano package: |
Just so it doesn't get lost in the closed funcscan thread: We ended up mounting a dummy file (the bash binary of the execution node) but with the name PKG_INFO: Also I see lower down in the script execution that we also make a directory for theanos which you may also have to do for cases of singularity (if you use that)
I hope that helps/works for you! |
Thank you for your answer @jfy133 ! I'll see if it works for me ! |
I did something here, but forgot what I wanted to do ;) maybe useful hugolefeuvre#1 ? |
It was maybe about the message I send on galaxy-iuc on Element ?
And you answered
But beyond that I think it can be useful in any case. |
deeparg changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @hugolefeuvre its now green.
I added a few more comments, they apply to both tools :)
@bernt-matthias can you maybe look at the DM bits here? |
data_managers/data_manager_deeparg/data_manager/data_manager_deeparg.xml
Outdated
Show resolved
Hide resolved
data_managers/data_manager_deeparg/data_manager/data_manager_deeparg.xml
Outdated
Show resolved
Hide resolved
</configfiles> | ||
<inputs> | ||
<param name="version" type="select" label="DB version"> | ||
<option value="1.0.4" selected="true">Data needed for running DeepARG v1.0.4</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use @TOOL_VERSION@
here instead of 1.0.4
?
Do you know if the tool can also download other versions. Do you know if future versions can use older downloads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think we can.
The tool download all the versions (v1 and v2), and then you can choose version with a deeparg predict parameter --model-version
There is no information if future versions can use older downloads, actually all the versions are in the zenodo that is download by deeparg as database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share a link to the zenodo record?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<param name="input" type="data" format="fasta" label="Input file"/> | ||
<param name="deeparg_db" type="select" label="DeepARG database"> | ||
<options from_data_table="deeparg_database_versioned"> | ||
<validator message="No deeparg database is available" type="no_options"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we filter for the version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of filter did you have in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking to filter for the version, such that the corresponding tool version can only process the values generated with exactly this version .. not sure if it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure that the only DB that can be used is the one that corresponds to the version of the tool?
Someting like that ? <filter column="version" value="@TOOL_VERSION@"/>
Co-authored-by: Björn Grüning <[email protected]>
FOR CONTRIBUTOR: