Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make heavy dependency optional #330

Merged
merged 6 commits into from
Jan 18, 2025
Merged

Conversation

kripnerl
Copy link
Contributor

@kripnerl kripnerl commented Jan 14, 2025

Closes #280

  • Divide S3 and mongo dependencies into eventual groups.
  • Remove obsolete dependencies.
  • Add installation instructions.

@kripnerl kripnerl changed the title 261 make heavy dependency optional make heavy dependency optional Jan 14, 2025
@kripnerl
Copy link
Contributor Author

By the way, I did quite an ugly hack with tests to run. I'm not sure whether to leave it like this or find some more elegant solution.

If there are pytest I would add some flags to run some particular tests only if the selected package is installed. To be sure, that the library is not imported where it shouldn't be.

Nevertheless, I would appreciate this request to be merged as soon as possible since the dependency hell, which is (most likely) botocore causing is blocking me quite a lot - poetry lock file is being calculated for over several minutes. Otherwise it takes only few seconds.

@orso82
Copy link
Member

orso82 commented Jan 14, 2025

I don't think s3 and mongo are used much, if at all. I see regression tests passing, and I am supportive to merge.
@AreWeDreaming @smithsp @torrinba @hassec thoughts?

@AreWeDreaming
Copy link
Collaborator

I certainly don't use either of those with OMAS directly, but then I don't do a lot of database work overall.

@hassec
Copy link
Contributor

hassec commented Jan 14, 2025

Thanks for the ping @orso82, no objections from my side 👍

@smithsp
Copy link
Member

smithsp commented Jan 15, 2025

Good by me. Good to know.

@orso82 orso82 merged commit f4faa93 into master Jan 18, 2025
6 checks passed
@orso82 orso82 deleted the 261-make-heavy-dependency-optional branch January 18, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some serializers optionals
5 participants