Skip to content

Commit

Permalink
fix(ci): docker and electron publish (#160)
Browse files Browse the repository at this point in the history
  • Loading branch information
fynnfluegge authored Nov 18, 2024
1 parent cbfd312 commit 043db9b
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker-build-and-publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:

- name: Extract release tag
id: get_tag
run: echo "RELEASE_TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
run: echo "RELEASE_TAG=$GITHUB_REF_NAME" >> $GITHUB_ENV

- name: Build and push Docker image api
uses: docker/build-push-action@v5
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/electron-build-and-publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: macos-latest
strategy:
matrix:
node-version: [18.x]
Expand All @@ -33,9 +33,6 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Install Snapcraft
uses: samuelmeuli/action-snapcraft@v3

- name: Build electron app
run: |
cd webapp
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ It utilizes a [100% Serverless RAG pipeline](https://medium.com/@fynnfluegge/ser
- Run it 100% [locally with Docker](INSTALLATION.md#run-with-docker)
- Host at [AWS](INSTALLATION.md#aws-hosting)
- Check [Contribution Guide](CONTRIBUTING.md#contributing-guide) how to setup a local development environment
- If you are interested in contributing, visit [Contributing](README.md#Contributing) section for more details.
- If you are interested in contributing, visit [Contributing](README.md#contributing) section for more details.

## ✨ Features

Expand Down Expand Up @@ -109,7 +109,7 @@ It utilizes a [100% Serverless RAG pipeline](https://medium.com/@fynnfluegge/ser

## Contributing

A good way to do the first contribution are the *good first issue* labelled issues [here](https://github.com/fynnfluegge/rocketnotes/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22). On some of the issues are already linked PRs with comments in the code what has to be done. These PRs can be picked up if not assigned to someone yet.
A good way to do the first contribution are the _good first issue_ labelled issues [here](https://github.com/fynnfluegge/rocketnotes/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22). On some of the issues are already linked PRs with comments in the code what has to be done. These PRs can be picked up if not assigned to someone yet.

The most comfortable way to get started is to open the project in a ready-to-code Gitpod workspace with all packages & tools preinstalled and a running database with sample data.

Expand Down
2 changes: 1 addition & 1 deletion landing-page/src/app/app.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<a
class="nav-link border border-light rounded"
target="_blank"
href="https://rocketnotes-electron-releases.s3.eu-central-1.amazonaws.com/rocketnotes-1.0.0-arm64.dmg"
href="https://rocketnotes-electron-releases.s3.eu-central-1.amazonaws.com/rocketnotes-1.0.2-arm64.dmg"
style="margin-right: 8px"
>
<i class="fa-solid fa-download"></i> macOS <i class="fab fa-apple"></i>
Expand Down
4 changes: 2 additions & 2 deletions webapp/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "webapp",
"version": "1.0.0",
"version": "1.0.2",
"main": "electron.js",
"scripts": {
"ng": "ng",
Expand All @@ -12,7 +12,7 @@
"build": "npm run config-prod && ng build --configuration production",
"build-local": "export API_URL='http://localhost:3002' && npm run config-dev && ng build",
"build-electron": "npm run config-prod && ng build --configuration production --base-href ./",
"bundle-electron": "./node_modules/.bin/electron-builder --publish always",
"bundle-electron": "./node_modules/.bin/electron-builder --publish always --mac --arm64",
"test": "ng test"
},
"private": true,
Expand Down

0 comments on commit 043db9b

Please sign in to comment.