Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected doc string #75

Merged
merged 6 commits into from
Apr 5, 2024
Merged

corrected doc string #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a588a37
corrected doc string
shimwell Mar 31, 2024
f0d1b5d
Merge branch 'main' into tiny_fixes
shimwell Apr 5, 2024
7ef7c84
[skip ci] Apply formatting changes
shimwell Apr 5, 2024
3487513
corrected function name
shimwell Apr 5, 2024
56523aa
Update examples/surface_mesh/from_gmsh_mesh_file.py
shimwell Apr 5, 2024
c1ff68a
Merge branch 'main' into tiny_fixes
shimwell Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/surface_mesh/from_gmsh_mesh_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
# making use of the DAGMC file in OpenMC
import openmc

openmc.config["cross_sections"] = "/home/j/endf-b8.0-hdf5/endfb-viii.0-hdf5/cross_sections.xml"
openmc.config["cross_sections"] = "cross_sections.xml"

mat1 = openmc.Material(name="mat1")
mat1.add_nuclide("H1", 1, percent_type="ao")
Expand Down
9 changes: 3 additions & 6 deletions src/cad_to_dagmc/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,13 +236,10 @@ def _mesh_brep(
def mesh_to_vertices_and_triangles(
dims_and_vol_ids,
):
"""Converts gmsh volumes into a DAGMC h5m file.
"""Converts gmsh volumes into vertices and triangles for each face.

Args:
volumes: the volumes in the gmsh file, found with gmsh.model.occ.importShapes
material_tags: A list of material tags to tag the DAGMC volumes with.
Should be in the same order as the volumes
h5m_filename: the filename of the DAGMC h5m file to write

Returns:
vertices and triangles (grouped by solid then by face)
Expand Down Expand Up @@ -435,7 +432,7 @@ def export_unstructured_mesh_file(

imprinted_assembly, _ = cq.occ_impl.assembly.imprint(assembly)

gmsh, volumes = _mesh_brep(
gmsh, _ = _mesh_brep(
brep_object=imprinted_assembly.wrapped._address(),
min_mesh_size=min_mesh_size,
max_mesh_size=max_mesh_size,
Expand Down Expand Up @@ -480,7 +477,7 @@ def export_gmsh_mesh_file(

imprinted_assembly, _ = cq.occ_impl.assembly.imprint(assembly)

gmsh, volumes = _mesh_brep(
gmsh, _ = _mesh_brep(
brep_object=imprinted_assembly.wrapped._address(),
min_mesh_size=min_mesh_size,
max_mesh_size=max_mesh_size,
Expand Down
Loading