-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support directory (go package) execution #24
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikaverpil
force-pushed
the
rnd-run-testfolder-populate-statuses
branch
from
June 3, 2024 22:33
92efb71
to
0a2a67e
Compare
fredrikaverpil
force-pushed
the
rnd-run-testfolder-populate-statuses
branch
4 times, most recently
from
June 9, 2024 21:31
b553fa6
to
bf9e648
Compare
fredrikaverpil
force-pushed
the
rnd-run-testfolder-populate-statuses
branch
5 times, most recently
from
June 11, 2024 23:34
5ba2854
to
e01f4ad
Compare
fredrikaverpil
commented
Jun 12, 2024
lua/neotest-golang/results_dir.lua
Outdated
async.fn.writefile(test_properties.output, test_output_path) | ||
neotest_results[test_properties.node_data.id] = { | ||
status = test_properties.status, | ||
output = test_output_path, -- NOTE: could be slow when running many tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should definitively be configurable. To keep reliability/stability higher, it's possible that the default should be to disable this and instead refer to the full output here for each test.
fredrikaverpil
commented
Jun 12, 2024
fredrikaverpil
commented
Jun 12, 2024
fredrikaverpil
commented
Jun 13, 2024
fredrikaverpil
force-pushed
the
rnd-run-testfolder-populate-statuses
branch
5 times, most recently
from
June 15, 2024 08:56
2ebfc9f
to
e8b9e68
Compare
Use lazydev.nvim to play nice with LSP instead.
fredrikaverpil
force-pushed
the
rnd-run-testfolder-populate-statuses
branch
from
June 15, 2024 15:05
d3bc87f
to
ba05767
Compare
fredrikaverpil
force-pushed
the
rnd-run-testfolder-populate-statuses
branch
from
June 15, 2024 20:03
1924f9b
to
78a7fa0
Compare
fredrikaverpil
force-pushed
the
rnd-run-testfolder-populate-statuses
branch
from
June 15, 2024 20:10
78a7fa0
to
3006146
Compare
fredrikaverpil
force-pushed
the
rnd-run-testfolder-populate-statuses
branch
from
June 15, 2024 21:14
5b9a69a
to
0d58b21
Compare
I'm concluding the discovery process here, and closing this PR in favour for #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
runs one
go test
command. Could potentially and hopefully lay thefoundation for implementing a similar or the same behavior when running
all tests in a file.
What was changed
one
go test
command.go test
output and map the test name to the Neotest node id, returnstatus, output and errors per Neotest node id.
Notes
passing on my end now.
somehow, as you could time out more easily now in a large project.
running all tests in a file.
Try it out
Set the branch: