Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added batch start and end date validation #711

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

ph4ni
Copy link
Contributor

@ph4ni ph4ni commented Dec 23, 2023

Added validation for batch dates so that the end date will always be later than the start date.

@pateljannat
Copy link
Collaborator

pateljannat commented Dec 26, 2023

@ph4ni please add a description

lms/lms/doctype/lms_batch/lms_batch.py Outdated Show resolved Hide resolved
lms/lms/doctype/lms_batch/lms_batch.py Outdated Show resolved Hide resolved
lms/lms/doctype/lms_batch/lms_batch.py Outdated Show resolved Hide resolved
@ph4ni
Copy link
Contributor Author

ph4ni commented Dec 27, 2023

done

Copy link

cypress bot commented Dec 28, 2023

Passing run #459 ↗︎

0 1 0 0 Flakiness 0

Details:

Merge 8e7c1da into 4b4086a...
Project: lms Commit: 3d15f426bb ℹ️
Status: Passed Duration: 00:41 💡
Started: Feb 12, 2024 1:49 AM Ended: Feb 12, 2024 1:50 AM

Review all test suite changes for PR #711 ↗︎

@pateljannat pateljannat merged commit 97712db into frappe:main May 24, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants