Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: misc performance improvements #1259

Merged
merged 1 commit into from
Jan 17, 2025
Merged

perf: misc performance improvements #1259

merged 1 commit into from
Jan 17, 2025
+62 −97

Conversation

pateljannat
Copy link
Collaborator

  1. Added indexes for LMS Course Progress
  2. The allUsers function was a risk, so now only the Moderator, Course Creator, and Batch Evaluator can access this role. Its usage is only for mentions, so only these roles can use the mention functionality in discussions. Others can just send messages.

@cypress Cypress
Copy link

cypress bot commented Jan 17, 2025

lms    Run #992

Run Properties:  status check passed Passed #992  •  git commit d20c2cbe98 ℹ️: Merge 145342bb72498cee16535168251420cf11d69dda into 58abfd004d1fc7d04802069c134f...
Project lms
Branch Review issues-69
Run status status check passed Passed #992
Run duration 00m 29s
Commit git commit d20c2cbe98 ℹ️: Merge 145342bb72498cee16535168251420cf11d69dda into 58abfd004d1fc7d04802069c134f...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 828e195 into frappe:develop Jan 17, 2025
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot